elm-repl icon indicating copy to clipboard operation
elm-repl copied to clipboard

No Tests

Open maxsnew opened this issue 11 years ago • 2 comments

There are no tests, so we have no automated way of telling if we've broken previous behavior (like my recent pr).

Also, this repo could be used to test the Elm compiler itself and as such should be considered for merging into the main Elm repo.

I'm willing to work on this, but it would probably involve some rearchitecturing of existing code to make it more testable so I don't want to start until I have some kind of assurance that what I do will be accepted. Push access would also be nice :).

maxsnew avatar Dec 23 '13 22:12 maxsnew

I think testing would be very nice. I'm also hoping to work on an elm-unit in the future.

jcollard avatar Jan 13 '14 15:01 jcollard

Just made a lot of progress on this today. It involved some restructuring like I said, but now the command parser is imminently tested/testable: https://github.com/evancz/elm-repl/blob/ec1268b70ba93bf642701c211b1dfb8c10ef0945/tests/Main.hs.

Next I'm going to integrate the parsing from here: https://github.com/evancz/elm-repl/blob/dev/src/Environment.hs#L34-L68 into the input parsing phase so that can be tested easily too.

maxsnew avatar Jan 15 '14 08:01 maxsnew