elm-make icon indicating copy to clipboard operation
elm-make copied to clipboard

Javascript error for elm-package.json "repository" strings where the github username starts with a capital when built with '--debug'

Open NickAger opened this issue 8 years ago • 3 comments

Tested in 0.18

  • In an empty folder with http://elm-lang.org/examples/buttons create Buttons.elm.
  • elm package install accept plan.
  • elm reactor
  • Notice that http://localhost:8000/Buttons.elm works as expected.
  • Edit elm-package.json and change:
"repository": "https://github.com/user/project.git",

to:

"repository": "https://github.com/User/project.git",

that is user has changed to User.

  • navigate to http://localhost:8000/Buttons.elm again and notice the javascript error:
TypeError: undefined is not an object (evaluating '_elm_lang$core$Native_Scheduler.nativeBinding')
  • The problem only occurs if the first character of the github username is capitalised.
  • There is no problem if compiling without the --debug flag; that is elm-make Buttons.elm works as expected.
  • Whereas elm-make --debug Buttons.elm generates the javascript error.
  • Tested on Safari 10.0.1 and Chrome 54.0.2840.98

Thanks to @lorenzo on slack for locating the issue for me.

NickAger avatar Nov 16 '16 13:11 NickAger

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot avatar Nov 16 '16 13:11 process-bot

What are other strings you tried? What is the length where it starts messing up?

evancz avatar Nov 17 '16 00:11 evancz

@evancz it turns out not to be related to the length of the repository string, rather to capitalising the initial letter of the github username in the repository string. So the default works:

"repository": "https://github.com/user/project.git",

whereas changing user to User causes the javascript exception:

"repository": "https://github.com/User/project.git",

I've edited the title and description to match.

NickAger avatar Nov 17 '16 09:11 NickAger