beatsaver-laravel icon indicating copy to clipboard operation
beatsaver-laravel copied to clipboard

Published 20 hours ago • verified publisher icon elliotttate

store mp3 preview files (fixes #66)

Open ngokevin opened this issue 6 years ago • 9 comments

For reliable cross-browser audio previews and to support BeatSaver Viewer on platforms such as Safari/iOS. Went with MP3 over AAC due to Firefox support.

I guess optimally, these things would be done using a task queue, but I think the upload frequency is enough to do it on demand.

Using an exec / shell call-out vs php-ffmpeg because want to do it in background to not hold up the HTTP response.

ngokevin avatar Jan 30 '19 01:01 ngokevin

Is anyone open to check this out? Much appreciated!

ngokevin avatar Feb 01 '19 21:02 ngokevin

Done! I store it as their original filenames and handles per difficulty.

ngokevin avatar Feb 04 '19 16:02 ngokevin

I'll check it out later today

luludotdev avatar Feb 04 '19 17:02 luludotdev

@Assistant Also, are you handling the script for retroactive conversions?

ngokevin avatar Feb 05 '19 21:02 ngokevin

I can handle it, however I can't promise I'll be fast since I have a lot on my plate currently. If you want to help with it, that'd be welcome too.

Assistant avatar Feb 05 '19 21:02 Assistant

Sure. What kind of environment is it? Do I just need to write a script that manually runs in the storage directory?

ngokevin avatar Feb 05 '19 21:02 ngokevin

So good to go? I can write like a Node script that does the conversions in a queue if that sounds good.

ngokevin avatar Feb 06 '19 22:02 ngokevin

Sorry to bump this (also thanks for testing the spaces in paths!). Anything else to do after the PR gets approved?

ngokevin avatar Feb 12 '19 19:02 ngokevin

Since this is still a thing.... has anyone thought about using https://github.com/brion/ogv.js/

It’s the same setup Wikipedia uses to play ogg files one iOS

sinfuljosh avatar Feb 14 '20 06:02 sinfuljosh