disposable-emails-filter-php icon indicating copy to clipboard operation
disposable-emails-filter-php copied to clipboard

Modify function and property scopes

Open omarcinkonis opened this issue 8 months ago • 0 comments

Hello, from my research, it seems that this package has the most comprehensive blacklist out of all options. I would really like to use it, but I ran into a couple of problems

  1. I need to access the list of domains as array; getDomainsFromFile method is private and I cannot use it
  2. I would like to extend the Email class, but I cannot use private string $emailListPath; in my own methods

Suggestions:

  1. Update all private to protected so that the class can be extended
  2. (optional) Make getDomainsFromFile public

omarcinkonis avatar Jun 26 '24 08:06 omarcinkonis