calico
calico copied to clipboard
Fixed "none" TextAnimation
The "none" text animation has multiple bugs:
- the methods in the animation call Element methods with
this
instead ofel
-
Element.added()
should not set the opacity of the el to 0. It is the responsibility of the fade animation and that's what it does. Always setting the opacity to 0 doesn't make sense for the "none" animation and for any custom animation not based on opacity.
This PR fixes both issues.
Element.added() should not set the opacity of the el to 0. It is the responsibility of the fade animation and that's what it does. Always setting the opacity to 0 doesn't make sense for the "none" animation and for any custom animation not based on opacity.
It's been a while since I designed these systems, but from what I remember, this approach may have been necessary in order to make "fade in"-style animations work. I don't have time to verify this right now, but I'll get this resolved ASAP.
The fade animation does set the opacity to 0 itself in its added
function so removing it from Element.added does not break "fade" but fixes "none".