Cannot unmarshal to interface{}

[mitar]

It seems the following is not supported:

var d interface{}
err := phpserialize.Unmarshal(m, &d)

I wonder why? It would be nice to be able to just infer type? Especially given that there is typing information in PHP serialized string.

[elliotchance]

Indeed. I'm happy to accept a pull request for this.

[mitar]

I am not sure if I understand the PHP format well enough to contribute this myself.

[elliotchance]

Within Unmarshal you can replace these lines:

	default:
		return errors.New("can not unmarshal type: " + value.Kind().String())

With:

	default:
		v, _, err := consumeNext(data, 0)
		if err != nil {
			return err
		}

		value.Set(reflect.ValueOf(v))
		return nil

Add a few unit tests to be sure.

[studyzhanglei]

	var i map[string]interface{}

	if err = phpserialize.Unmarshal([]byte(syscache.Data), &i); err == nil {

		return ""
	}

panic: reflect.Set: value of type map[interface {}]interface {} is not assignable to type map[string]interface {} [recovered] panic: reflect.Set: value of type map[interface {}]interface {} is not assignable to type map[string]interface {}

[elliotchance]

panic: reflect.Set: value of type map[interface {}]interface {} is not assignable to type map[string]interface {}

The error message is pretty clear, you cannot use map[string]interface{} you have to use map[interface{}]interface{}. You will need to create the string-indexed map yourself.

[studyzhanglei]

panic: reflect.Set: value of type map[interface {}]interface {} is not assignable to type map[string]interface {}

The error message is pretty clear, you cannot use map[string]interface{} you have to use map[interface{}]interface{}. You will need to create the string-indexed map yourself.

Thanks, i overlooked that.

[whisky-rye]

Sure, I got panic like this: reflect.Set: value of type []interface {} is not assignable to type []string /root/go/pkg/mod/go.opentelemetry.io/otel/[email protected]/trace/span.go:383 (0x1040564) /root/go/pkg/mod/go.opentelemetry.io/otel/[email protected]/trace/span.go:421 (0x10404cc) /usr/local/go/src/runtime/panic.go:914 (0x43d05e) /usr/local/go/src/reflect/value.go:3307 (0x4db5c8) /usr/local/go/src/reflect/value.go:2260 (0x4d7645) /root/go/pkg/mod/github.com/elliotchance/[email protected]/unserialize.go:188 (0x1124535)

Even I must replace make([]string{}, 0) to make([]interface{}, 0), but then I have to item.(string) get the value for string. So, If you define the slice type into function phpserialize.Unmarshal, the items of slice must be type interface.

[elliotchance]

@mysticzhong I'm happy to accept a PR if you want to support that, otherwise casting is the way to go.