Elliot Huffman

Results 43 comments of Elliot Huffman

Hi @spinalgr1990, I will look into this, so far based upon initial investigation, it looks like I can do this. I have decided to archive teh python version in favor...

I made a PR that should help with this issue: #1624 This PR will allow you to configure your auth system the way you need and just pass the credential...

From the authentication side of things, the new PR at #1624 should add authentication support as you can roll any authentication you need from the MSFT side of things. You...

> Sweet, this looks great! Can you fix the formatting to use 2 spaces instead of tabs? 🙇 Fixed! I also bumped the `@Azure/Identity` package to the latest version as...

> Would you mind updating the lock file as well? That would be important. One sec.

I believe it is fixed now. I found an unrelated bug when I added some types to variables as part of this change. It was a bug where the access...

> Also, in general I'd be in favor of deprecating (and removing) the other azure identity related authentication methods - it would allow us to completely drop the runtime dependency...

> I had some more time to look at this and think about this. 😅 > > How do you feel about renaming the credential method to `azure-identity-token-credential`, and change...

It looks like it ran successfully, it is just failing to connect to codecov? I could be wrong; I don't use that service yet. @arthurschreiber, any todo items for me?

> Would you be okay with me taking the changes done so far in here and opening a new PR? I'd like to make sure we have tests running for...