Elkarte icon indicating copy to clipboard operation
Elkarte copied to clipboard

Logout confirmation on no session token and redirects

Open Vekseid opened this issue 4 years ago • 2 comments

Feature request for some nice compatibility with the MediaWiki extension I wrote. See @jdarwood007 's post here:

https://github.com/SimpleMachines/smf-mw-auth/issues/11#issuecomment-552164010

There are two separate issues that are occurring, because session data can no longer be communicated between Mediawiki and SMF/Elkarte.

The first is I can't pass a proper logout token. The easy solution here is that when someone visits action=logout, rather than throw a session verification failed error, instead ask them if they want to log out.

The more complicated issue is trying to provide redirects to the previous wiki page. I'm not sure if it is terribly worth it to give much thought to, but coming up with something might be a nice 2.0 feature.

Vekseid avatar Nov 11 '19 04:11 Vekseid

The logout confirmation w/o session makes a lot of sense and is easy to do. Not sure on how to best handle redirects between the two, but it would be nice to have.

Spuds avatar Nov 11 '19 15:11 Spuds

@Spuds If I get time this weekend, I was going to write up a solution for 2.1 as a PR. But looking quickly at Elkarte, I don't see the needed components. But the same idea could apply if you apply the similar idea. I've worked on changes to the base that @Vekseid wrote which is changing a bit of the extension but will work with it.

jdarwood007 avatar Nov 12 '19 00:11 jdarwood007