elk icon indicating copy to clipboard operation
elk copied to clipboard

Emojis are different in the editor and in the emoji picker

Open patak-dev opened this issue 2 years ago • 6 comments

Pre-Checks

  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
  • [X] Providing a screenshot or video to reproduce the issue or show visually what was meant.
  • [ ] I am willing to provide a PR.

Describe the bug

I don't know if this is solvable, but opening an issue to find out if that is the case

How it looks on Chrome/MacOS

image

Reproduction video or screenshot

No response

Additional Context

No response

patak-dev avatar Jan 17 '23 14:01 patak-dev

Solve in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Jan 17 '23 14:01 stackblitz[bot]

I found that OS renders emojis of emoji-picker, but actually it is inserted into editor as a picture.

In Windows and Edge (from MacOS virtual machine)

image

alexzhang1030 avatar Jan 17 '23 15:01 alexzhang1030

I found that OS renders emojis of emoji-picker, but actually it is inserted into editor as a picture.

Yes, it seems the issue is the emoji picker uses the user's system's default emoji font, while the composer uses Twemoji.

ZMYaro avatar Jan 18 '23 19:01 ZMYaro

Custom emoji picker that uses emojis available in Elk is in development. It is a complex task, so it will take a while.

cyberalien avatar Jan 19 '23 08:01 cyberalien

@cyberalien we can just switch the emoji set to twitter one emoji-mart already support it 😉

piotrski avatar Jan 20 '23 14:01 piotrski

@cyberalien we can just switch the emoji set to twitter one emoji-mart already support it 😉

Yes, I think for now it makes sense. Even though emoji set can be configured, it is not trivial to switch yet, so I doubt anyone would change them.

When all emoji stuff will be ready, including configurable sets and emoji picker, it can be switched to new code.

cyberalien avatar Jan 20 '23 15:01 cyberalien