elk icon indicating copy to clipboard operation
elk copied to clipboard

feat: add current user following hashtags page

Open alexzhang1030 opened this issue 2 years ago • 12 comments

Description

closes #1194

Add current user following hashtags page:

PC: image

Mobile:

image

Additional context

If servers are not support this feature, will return 404 error with this message:

image

Should we solve this specific case ?


What is the purpose of this pull request?

  • [ ] Bug fix
  • [x] New Feature
  • [ ] Documentation update
  • [ ] Translations update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [x] Read the Contributing Guidelines.
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide related snapshots or videos.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

alexzhang1030 avatar Jan 17 '23 09:01 alexzhang1030

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Jan 17 '23 09:01 stackblitz[bot]

Deploy Preview for elk-docs canceled.

Name Link
Latest commit f9d78fc61e683421aaaf759bfd90cdca5e76fbb9
Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63c68453e5a44200086e4495

netlify[bot] avatar Jan 17 '23 09:01 netlify[bot]

Have not reviewed the code and somehow there is no netlify preview

  1. Are the hashtags clickable so you can jump to the hashtag site itself?
  2. Is it possible to show a possibility to unfollow a hashtag from this site directly without jumping into the specific site?

Shinigami92 avatar Jan 17 '23 09:01 Shinigami92

Have not reviewed the code and somehow there is no netlify preview

  1. Are the hashtags clickable so you can jump to the hashtag site itself?
  2. Is it possible to show a possibility to unfollow a hashtag from this site directly without jumping into the specific site?

It uses the same component with explore/tags

image

So:

  1. Elk can show tags contents, and this is clickable.
  2. We can follow/unfollow by here ↓
image

alexzhang1030 avatar Jan 17 '23 10:01 alexzhang1030

Interesting, I didn't know this tab/view/component

We could add my idea in another PR later 👌


btw: I implemented the star for follow/unfollow a tag 😉

Shinigami92 avatar Jan 17 '23 10:01 Shinigami92

Deploy Preview for elk-zone ready!

Name Link
Latest commit f9d78fc61e683421aaaf759bfd90cdca5e76fbb9
Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63c68453088b5100084d7697
Deploy Preview https://deploy-preview-1251--elk-zone.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jan 17 '23 10:01 netlify[bot]

Interesting, I didn't know this tab/view/component

We could add my idea in another PR later 👌

btw: I implemented the star for follow/unfollow a tag 😉

For my personal thoughts, the color of the star is a little unclear.

Maybe we could add a conspicuous color ? 🤔

alexzhang1030 avatar Jan 17 '23 10:01 alexzhang1030

maybe we can move it to more action menu. it looks too obtrusive on mobile devices. image

sxzz avatar Jan 17 '23 10:01 sxzz

Agree, Let's try it out.

alexzhang1030 avatar Jan 17 '23 10:01 alexzhang1030

Update

Now it is placed at account more:

image

PC:

image

Mobile:

image

alexzhang1030 avatar Jan 17 '23 11:01 alexzhang1030

I think users may not need to follow/unfollow tags too many times, so it may be better to hide this screen a bit more. The official Mastodon app has it in Settings, maybe we should move it there too? image

patak-dev avatar Jan 17 '23 21:01 patak-dev

I think users may not need to follow/unfollow tags too many times, so it may be better to hide this screen a bit more. The official Mastodon app has it in Settings, maybe we should move it there too? image

I guess this is an anthor feature, the related issue in mastodon is still open

alexzhang1030 avatar Jan 18 '23 02:01 alexzhang1030

As this is currently on the official Mastodon as a feature, would be great to see it in Elk as well!

ronilaukkarinen avatar Feb 19 '23 12:02 ronilaukkarinen

This is helpful for unfollowing tags, otherwise I might only unfollow tags on mastodon 🙏

Sma11X avatar Sep 15 '23 08:09 Sma11X

#1251 implemented the hashtags page as an independent page with the star follow button.

shuuji3 avatar Apr 03 '24 14:04 shuuji3