elk icon indicating copy to clipboard operation
elk copied to clipboard

Published 20 hours ago • verified publisher icon elk-zone

More appropriate placement of `Translate` button.

Open Icy-Thought opened this issue 2 years ago • 7 comments

Clear and concise description of the problem

The translation button is placed in a hidden location at the moment. It also takes two clicks to achieve the desired effect (assuming the translation does not fail, like I'd encountered a couple of times earlier).

Suggested solution

Create a translation button which appears under the text of the toot only if the user languages does not match the language of the written toot.

Design example: ICON + Translate toot to X language. (or without the X language)

Alternative

No response

Additional context

No response

Icy-Thought avatar Jan 14 '23 12:01 Icy-Thought

Solve in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Jan 14 '23 12:01 stackblitz[bot]

This issue is only partially solved. The link always appears if the language of the toot isn't English, but it doesn't take into account the language of the user

haayman avatar Jan 16 '23 19:01 haayman

This issue is only partially solved. The link always appears if the language of the toot isn't English, but it doesn't take into account the language of the user

related: https://github.com/elk-zone/elk/issues/1247

Looks like this is not a BUG. /cc @danielroe

alexzhang1030 avatar Jan 17 '23 12:01 alexzhang1030

I do think it is a bug. Even though it is probably true that most people leave the language of a toot to English/UK, the translate link should appear on every English toot if I set my preferred language to e.g. Dutch. This is not the case. None of the English toots get a translate link, all (most) the Dutch toots do get a link

haayman avatar Jan 17 '23 13:01 haayman

I do think it is a bug. Even though it is probably true that most people leave the language of a toot to English/UK, the translate link should appear on every English toot if I set my preferred language to e.g. Dutch. This is not the case. None of the English toots get a translate link, all (most) the Dutch toots do get a link

I will fix it then.

alexzhang1030 avatar Jan 17 '23 13:01 alexzhang1030

So could you check now this behavour meet your expectations？@haayman

I updated yesterday.

alexzhang1030 avatar Jan 18 '23 03:01 alexzhang1030

Yes this looks perfect. None of the Dutch toots have a link, all the English ones do. Excellent

haayman avatar Jan 18 '23 05:01 haayman