elk icon indicating copy to clipboard operation
elk copied to clipboard

"Always expand content warnings" and "always show media" settings do not transfer and are not findable

Open forestsystem opened this issue 2 years ago • 4 comments

Pre-Checks

  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
  • [X] Providing a screenshot or video to reproduce the issue or show visually what was meant.
  • [ ] I am willing to provide a PR.

Describe the bug

I've never submitted a bug report here before. I copied this format from a couple other issues. Please be gentle if I messed up!

Clear and concise description of the problem

I have the "Always expand posts marked with content warnings" and "Always show media" settings enabled on disabled.social.

When I logged into Elk, posts marked with content warnings and posts with just media marked as sensitive both stayed hidden, the default setting on Mastodon. I looked for a way to turn these settings back on and could not find it.

Suggested solution

Make it so these settings transfer into Elk when someone logs in, like how my filters transferred just fine.

Alternative

Add an easy-to-find way to re-enable these settings after logging into Elk.

Additional context

If it's relevant, I'm on disabled.social, and I'm using Firefox on desktop. I've also attached a screenshot of one of the posts with a content warning that didn't expand, since the pre-check said to add a screenshot, though I'm not sure how helpful that is in this case.

Thank you for making this client!

Reproduction video or screenshot

image

Additional Context

No response

forestsystem avatar Jan 12 '23 12:01 forestsystem

Solve in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Jan 12 '23 12:01 stackblitz[bot]

Thanks for filing the issue! I think this is just a setting we have not implemented on Elk yet. So I will label it as a feature request :)

ayoayco avatar Jan 12 '23 21:01 ayoayco

@forestsystem Can you attach a screenshot of the settings in mastodon where you set this up to help the dev?

ayoayco avatar Jan 12 '23 21:01 ayoayco

Here! It's at the bottom of the page on https://[the instance]/settings/preferences/appearance: image image

forestsystem avatar Jan 12 '23 22:01 forestsystem

It looks like this was fixed in v0.9.4

jasonbrooks avatar May 04 '23 22:05 jasonbrooks

Indeed! Does it also apply "always show media" and can we close this? cc @patak-dev

ayoayco avatar May 04 '23 23:05 ayoayco

Easy to support now but not implemented, check https://github.com/elk-zone/elk/commit/16561845f8926366d8998bf33e2d81089b0037b0. PR welcome!

patak-dev avatar May 05 '23 05:05 patak-dev

Looks good, I'll try the other preference.

ayoayco avatar May 05 '23 06:05 ayoayco