eliza icon indicating copy to clipboard operation
eliza copied to clipboard

fix: fixing failing goals, cache and token tests

Open ai16z-demirix opened this issue 1 year ago • 3 comments

Relates to:

https://github.com/ai16z/eliza/issues/519

Risks

low - fixing tests

Background

What does this PR do?

Fixing goals, cache and token tests

What kind of change is this?

Bug-fixes

Fixing tests to prevent flaky tests.

Documentation changes needed?

None

Testing

Where should a reviewer start?

navigate to packages/core

Detailed testing steps

run pnpm install, pnpm test

ai16z-demirix avatar Nov 22 '24 22:11 ai16z-demirix

Hello @pgoos thanks for reaching out! Yes, I have run tests locally multiple times before creating the PR. You should maybe try runing pnpm test, instead of npm test. Honestly, I am confused with this error: No test files found, exiting with code 1 Are you sure that you are executing tests in packages/core directory? This is my output: Screenshot from 2024-11-23 18-10-09

The other error with @ai16z/plugin-solana persisted also on my local until I ran pnpm build. We can figure this out, there is problem with imports definitely.

ai16z-demirix avatar Nov 23 '24 17:11 ai16z-demirix

@lalalune Fixed! Thank you for this input. Fixed package.json file and moved token.test to solana plugin. Added vitest to that package. Tests are running properly now.

ai16z-demirix avatar Nov 24 '24 14:11 ai16z-demirix