fix: ignored modelEndpointOverride in generation
Background
What does this PR do?
This PR fixes the issue of OpenAi object initialization which ignores the modelEndpointOverride optioin of the character
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
will this break if it is nul?
Thanks @darwintree for addressing the issue with OpenAI object initialization and ensuring the modelEndpointOverride is respected. Could you please add a test to validate the changes made in this PR? Specifically:
- A test to ensure that the
baseURLis properly set whenmodelEndpointOverrideis provided. - A test to verify that the functionality does not break when
modelEndpointOverride(orbaseURL) isnullor undefined.
This will help confirm that the changes work as expected and ensure robustness. Let me know if you need further clarification or help setting up the test!
will this break if it is nul?
Thanks, I ignored the situation that it could be null. A fix is commited to resolve the issue
Thanks @darwintree for addressing the issue with OpenAI object initialization and ensuring the
modelEndpointOverrideis respected. Could you please add a test to validate the changes made in this PR? Specifically:
- A test to ensure that the
baseURLis properly set whenmodelEndpointOverrideis provided.- A test to verify that the functionality does not break when
modelEndpointOverride(orbaseURL) isnullor undefined.This will help confirm that the changes work as expected and ensure robustness. Let me know if you need further clarification or help setting up the test!
Hi, would know how to setup and run the test. Thanks