eliza icon indicating copy to clipboard operation
eliza copied to clipboard

fix: ignored modelEndpointOverride in generation

Open darwintree opened this issue 1 year ago • 4 comments

Background

What does this PR do?

This PR fixes the issue of OpenAi object initialization which ignores the modelEndpointOverride optioin of the character

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

darwintree avatar Nov 20 '24 10:11 darwintree

will this break if it is nul?

ponderingdemocritus avatar Nov 20 '24 10:11 ponderingdemocritus

Thanks @darwintree for addressing the issue with OpenAI object initialization and ensuring the modelEndpointOverride is respected. Could you please add a test to validate the changes made in this PR? Specifically:

  1. A test to ensure that the baseURL is properly set when modelEndpointOverride is provided.
  2. A test to verify that the functionality does not break when modelEndpointOverride (or baseURL) is null or undefined.

This will help confirm that the changes work as expected and ensure robustness. Let me know if you need further clarification or help setting up the test!

snobbee avatar Nov 20 '24 14:11 snobbee

will this break if it is nul?

Thanks, I ignored the situation that it could be null. A fix is commited to resolve the issue

darwintree avatar Nov 21 '24 01:11 darwintree

Thanks @darwintree for addressing the issue with OpenAI object initialization and ensuring the modelEndpointOverride is respected. Could you please add a test to validate the changes made in this PR? Specifically:

  1. A test to ensure that the baseURL is properly set when modelEndpointOverride is provided.
  2. A test to verify that the functionality does not break when modelEndpointOverride (or baseURL) is null or undefined.

This will help confirm that the changes work as expected and ensure robustness. Let me know if you need further clarification or help setting up the test!

Hi, would know how to setup and run the test. Thanks

darwintree avatar Nov 21 '24 01:11 darwintree