Fix linter issues
Relates to:
No specific issue linked - appears to be a code quality improvement PR
Risks
Low - Changes are purely related to code style and import organization with no functional changes.
Background
What does this PR do?
This PR addresses linting issues in the codebase by:
- Reorganizing and consolidating imports
- Removing unused imports
- Removing empty catch variable declarations
- Fixing import ordering
- Removing extra blank lines
What kind of change is this?
Improvements (misc. changes to existing features)
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Review the changes in the following files:
- packages/core/src/embedding.ts
- packages/core/src/generation.ts
- packages/core/src/parsing.ts
Detailed testing steps
No, automated tests are fine. These changes are purely syntactic and don't affect functionality.
The changes include:
- Import reorganization
- Removal of unused imports (fs)
- Simplifying catch blocks by removing unused error variables
- Consistent import ordering
Since these are linter-driven changes, existing tests should cover functionality verification.
LGTM outside of adding console.error for the catch statements
@monilpat @martincik We have a build error, can we address before merge?
1s
20s
59s
6s
0s
3s
Run pnpm run build
> eliza@ build /home/runner/work/eliza/eliza
> bash ./scripts/build.sh
Building package: core
> @ai[1](https://github.com/ai16z/eliza/actions/runs/11891646673/job/33225640865?pr=397#step:8:1)6z/[email protected] build
> tsup --format esm --dts
CLI Building entry: src/index.ts
CLI Using tsconfig: tsconfig.json
CLI tsup v8.3.5
CLI Using tsup config: /home/runner/work/eliza/eliza/packages/core/tsup.config.ts
CLI Target: esnext
CLI Cleaning output folder
ESM Build start
ESM dist/index.js 108.07 KB
ESM dist/index.js.map 25[6](https://github.com/ai16z/eliza/actions/runs/11891646673/job/33225640865?pr=397#step:8:7).62 KB
ESM ⚡️ Build success in 3[7](https://github.com/ai16z/eliza/actions/runs/11891646673/job/33225640865?pr=397#step:8:8)ms
DTS Build start
Error: src/embedding.ts(3,10): error TS2300: Duplicate identifier 'models'.
Error: src/embedding.ts(4,10): error TS2300: Duplicate identifier 'IAgentRuntime'.
Error: src/embedding.ts(4,25): error TS2300: Duplicate identifier 'ModelProviderName'.
Error: src/embedding.ts(4,44): error TS2300: Duplicate identifier 'ModelClass'.
Error: src/embedding.ts([8](https://github.com/ai16z/eliza/actions/runs/11891646673/job/33225640865?pr=397#step:8:9),10): error TS2300: Duplicate identifier 'models'.
Error: src/embedding.ts([10](https://github.com/ai16z/eliza/actions/runs/11891646673/job/33225640865?pr=397#step:8:11),10): error TS2300: Duplicate identifier 'IAgentRuntime'.
Error: src/embedding.ts(10,25): error TS2300: Duplicate identifier 'ModelClass'.
Error: src/embedding.ts(10,37): error TS2300: Duplicate identifier 'ModelProviderName'.
Error: error occurred in dts build
at Worker.<anonymous> (/home/runner/work/eliza/eliza/node_modules/tsup/dist/index.js:[15](https://github.com/ai16z/eliza/actions/runs/11891646673/job/33225640865?pr=397#step:8:16)41:26)
at Worker.emit (node:events:507:28)
at MessagePort.<anonymous> (node:internal/worker:267:53)
at [nodejs.internal.kHybridDispatch] (node:internal/event_target:827:[20](https://github.com/ai16z/eliza/actions/runs/11891646673/job/33225640865?pr=397#step:8:21))
at MessagePort.<anonymous> (node:internal/per_context/messageport:[23](https://github.com/ai16z/eliza/actions/runs/11891646673/job/33225640865?pr=397#step:8:24):28)
DTS Build error
Failed to build core
ELIFECYCLE Command failed with exit code 1.
Error: Process completed with exit code 1.
0s
@jkbrooks Build and lint fixed.