eliza icon indicating copy to clipboard operation
eliza copied to clipboard

fix: Update package.json of core package

Open kesar opened this issue 11 months ago • 7 comments

these packages are being used in prod build and generate errors if you decide to just use this package in a project.

Background

These packages are being used under src/ folder and needs to be part of the dependencies not dev dependencies. If you try to build a project using only the core package, you will get errors that those packages are not installed

image

kesar avatar Jan 14 '25 18:01 kesar

While I haven't seen or experience this error, can you specify how we can reproduce this error?

shakkernerd avatar Jan 15 '25 02:01 shakkernerd

@tcm390 Tavily popping up in here

shakkernerd avatar Jan 15 '25 03:01 shakkernerd

While I haven't seen or experience this error, can you specify how we can reproduce this error?

I created an empty project and added pnpm add @elizaos/core to use it. (node 23.6)

as those packages are devdependencies dont get added to the bundle and get this error

kesar avatar Jan 15 '25 10:01 kesar

You haven't actually made any changes? The lines of code you've replaced are identical

0xSero avatar Jan 15 '25 12:01 0xSero

You haven't actually made any changes? The lines of code you've replaced are identical

Moved packages from devdependency to dependency since they are libs that are used in the src folder and are not for development (like jest, etc)

kesar avatar Jan 15 '25 12:01 kesar

@wtfsayo can u explain why you closed it? thanks!

kesar avatar Jan 15 '25 13:01 kesar

@wtfsayo can u explain why you closed it? thanks!

reopened

wtfsayo avatar Jan 15 '25 13:01 wtfsayo