fix: refactor Twitter client test mocks

[wizardsupreme]

Relates to

Improving test infrastructure and type safety in Twitter client tests

Risks

Low - Most changes are isolated to test files. The only production code change is setting TWITTER_MAX_TWEETS_PER_DAY to default to 10 tweets per day if not specified. This maintains existing behavior as seen in tests.

Background

What does this PR do?

• Keep env property in test runtime mocks for better real-world simulation
• Add TestAgentRuntime type to handle type safety in test mocks without implementing full IAgentRuntime interface (30+ properties)
• Remove duplicate TWITTER_MAX_TWEET_LENGTH in favor of MAX_TWEET_LENGTH
• Add TWITTER_MAX_TWEETS_PER_DAY to schema with default value of 10 tweets per day
• Standardize mock configuration across test files
• Fix type casting issues in environment tests

This change improves type safety while maintaining realistic test scenarios and reduces test complexity by only mocking necessary runtime properties.

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

1. packages/client-twitter/tests/environment.test.ts
2. packages/client-twitter/tests/base.test.ts
3. packages/client-twitter/tests/post.test.ts

Detailed testing steps

• Run the Twitter client tests:

  cd packages/client-twitter
  pnpm test
  

• Verify all Twitter client tests pass
• Check that mock configurations are consistent across test files
• Verify the build succeeds:

  cd packages/client-twitter
  pnpm build
  

Discord username

wizardsupreme

[wtfsayo]

@coderabbitai review

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces enhancements to the Twitter client configuration, specifically focusing on test utilities and environment settings. Key modifications include the addition of new properties to the mockConfig and mockRuntime objects, updates to type handling with the introduction of TestAgentRuntime, and the incorporation of a new field, TWITTER_MAX_TWEETS_PER_DAY, in the environment schema. These changes aim to expand the testing capabilities and improve configuration management within the Twitter client.

Changes

File	Change Summary
packages/client-twitter/__tests__/base.test.ts	- Added new config properties: TWITTER_PASSWORD, TWITTER_EMAIL, TWITTER_2FA_SECRET, TWITTER_RETRY_LIMIT, TWITTER_POLL_INTERVAL, MAX_ACTIONS_PROCESSING, ACTION_TIMELINE_TYPE (set to ActionTimelineType.ForYou) - Renamed TWITTER_MAX_TWEET_LENGTH to MAX_TWEET_LENGTH
packages/client-twitter/__tests__/environment.test.ts	- Updated runtime object types from IAgentRuntime to TestAgentRuntime - Removed TWITTER_MAX_TWEET_LENGTH from runtime configuration - Modified values for TWITTER_EMAIL and TWITTER_PASSWORD
packages/client-twitter/__tests__/post.test.ts	- Added ActionTimelineType import - Added new config properties: TWITTER_2FA_SECRET, TWITTER_RETRY_LIMIT, TWITTER_POLL_INTERVAL, MAX_ACTIONS_PROCESSING, ACTION_TIMELINE_TYPE (set to ActionTimelineType.ForYou) - Renamed TWITTER_MAX_TWEET_LENGTH to MAX_TWEET_LENGTH
packages/client-twitter/__tests__/test-utils.ts	- Introduced new TestAgentRuntime type for testing - Added asIAgentRuntime function for type casting
packages/client-twitter/src/environment.ts	- Added TWITTER_MAX_TWEETS_PER_DAY field to environment schema - Updated validateTwitterConfig to parse new field

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions[bot]]

This pull request has been automatically marked as stale due to 30 days of inactivity. If no further activity occurs within 7 days, it will be closed automatically. Please take action if this pull request is still relevant.