eliza icon indicating copy to clipboard operation
eliza copied to clipboard

feat: Adding plugin for B² Network

Open threewebcode opened this issue 11 months ago • 9 comments

B² Network is a Bitcoin Layer2 network. Add this plugin to integrate with Eliza so that users can interact with B² Network through Eliza agent.

Relates to

Add B² Network plugin into Eliza system.

Risks

Low

Main implementation risk is that the Plugin doesn't work correctly.

Background

What does this PR do?

B² Network is the first Bitcoin Rollup based on zero-knowledge proof verification commitment, while also offering a DA Layer solution for other Bitcoin rollups.

Adds support for Eliza to interact with B² Network and allows users to interact with B² Network through Eliza agent.

What kind of change is this?

Features (non-breaking change which adds functionality).

Documentation changes needed?

If documentation change is needed: I have updated the documentation accordingly.

Testing

Where should a reviewer start?

Spin up an agent with the b2 plugin

Detailed testing steps

Please refer to REAME.md in this plugin

threewebcode avatar Jan 08 '25 08:01 threewebcode

@shakkernerd Could you please help review this PR?

threewebcode avatar Jan 13 '25 01:01 threewebcode

@shakkernerd Could you please help review this PR?

Okay, I will look into it.

shakkernerd avatar Jan 13 '25 01:01 shakkernerd

Is it me blind or we miss agent/index.ts and the .json ? Sorry if they are present I was checking from the phone.

AIFlowML avatar Jan 13 '25 02:01 AIFlowML

Is it me blind or we miss agent/index.ts and the .json ? Sorry if they are present I was checking from the phone.

It is in the changed file list. Their order numbers are 5 and 37 . You can see it from following screenshot.

What he meant is the implementation of your plugin in agent/src/index.ts is missing. And to do this, you'll need to add/install your plugin to agent/package.json. You can check how other plugins are implemented for an idea on how this is done OR I can help do this later on.

shakkernerd avatar Jan 13 '25 02:01 shakkernerd

@threewebcode Basically, I can see repeated patterns in the code and I have commented on most, kindly use those comments to make the necessary adjustments.

Thanks for your feedback. All of them are resolved.

threewebcode avatar Jan 13 '25 05:01 threewebcode

@threewebcode Basically, I can see repeated patterns in the code and I have commented on most, kindly use those comments to make the necessary adjustments.

Thanks for your feedback. All of them are resolved.

You are welcome. I added a few above. Kindly resolve those and this is good to go.

shakkernerd avatar Jan 13 '25 06:01 shakkernerd

@threewebcode Basically, I can see repeated patterns in the code and I have commented on most, kindly use those comments to make the necessary adjustments.

Thanks for your feedback. All of them are resolved.

You are welcome. I added a few above. Kindly resolve those and this is good to go.

Please help take a look again.

threewebcode avatar Jan 13 '25 06:01 threewebcode

@threewebcode Basically, I can see repeated patterns in the code and I have commented on most, kindly use those comments to make the necessary adjustments.

Thanks for your feedback. All of them are resolved.

You are welcome. I added a few above. Kindly resolve those and this is good to go.

Please help take a look again.

A few of the changes aren't done yet.

shakkernerd avatar Jan 13 '25 06:01 shakkernerd

@threewebcode Basically, I can see repeated patterns in the code and I have commented on most, kindly use those comments to make the necessary adjustments.

Thanks for your feedback. All of them are resolved.

You are welcome. I added a few above. Kindly resolve those and this is good to go.

Please help take a look again.

A few of the changes aren't done yet.

Sorry. I can not see any new comments added by you. Could you please clarify them?. Moreover, there is no unresolved code review conversation above.

threewebcode avatar Jan 13 '25 07:01 threewebcode

@threewebcode Basically, I can see repeated patterns in the code and I have commented on most, kindly use those comments to make the necessary adjustments.

Thanks for your feedback. All of them are resolved.

You are welcome. I added a few above. Kindly resolve those and this is good to go.

Please help take a look again.

A few of the changes aren't done yet.

Sorry. I can not see any new comments added by you. Could you please clarify them?. Moreover, there is no unresolved code review conversation above.

image image image

shakkernerd avatar Jan 13 '25 15:01 shakkernerd

@threewebcode Basically, I can see repeated patterns in the code and I have commented on most, kindly use those comments to make the necessary adjustments.

Thanks for your feedback. All of them are resolved.

You are welcome. I added a few above. Kindly resolve those and this is good to go.

Please help take a look again.

A few of the changes aren't done yet.

Sorry. I can not see any new comments added by you. Could you please clarify them?. Moreover, there is no unresolved code review conversation above.

image image image

@shakkernerd Thanks for your helpful review and detailed instructions. The codes are refactored and refined. Please take a look again.

threewebcode avatar Jan 14 '25 00:01 threewebcode