fix: Twitter login notifications, incorrect cookie management.
Relates to:
No issue.
Risks
LOW - could break logins, but I tested.
Background
I noticed multiple login notifications in twitter:
My previous changes were not fully correct.
What does this PR do?
Handles twitter cookies better in twitter without re-triggering login() each time.
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Why are we doing this? Any context or related work?
I recently pushed: https://github.com/ai16z/eliza/pull/1288
Not sure if my PR broke this, or was always issue, but now fixed, not getting notifications anymore with cached cookies.
Documentation changes needed?
My changes do not require a change to the project documentation.
I cleared cache and watch the twitter login notifications in app. No longer getting notifications of "new login".
Testing
Where should a reviewer start?
Try login twice with cached cookies and should see no more new login notifications.
Detailed testing steps
None, automated tests are fine.
Discord username
cjft
I highly recommend merge this before new release, required fix, also CI is failing:
Skipping integration tests due to missing required API keys
Error: Process completed with exit code 1.```