eliza icon indicating copy to clipboard operation
eliza copied to clipboard

fix: Duplicate twitter posts.

Open ChristopherTrimboli opened this issue 1 year ago • 2 comments

Relates to:

https://github.com/ai16z/eliza/issues/1284

Risks

LOW - could miss a post, or post less, but seems posting once correctly now on server boot.

Background

What does this PR do?

This PR fixes duplicate Twitter posts on Eliza server boot.

I think this was a mistake from a revert last week, can see git blame:

image

generateNewTweetLoop() is being ran twice with no conditionals on post.start()

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Why are we doing this? Any context or related work?

Twitter agents should not duplicate post on boot.

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Before boot, see duplicates, after changes, only 1 post:

Screenshot From 2024-12-21 03-19-29

Where should a reviewer start?

Try boot twitter agent with fresh delay, note no duplicate posts.

Detailed testing steps

Start with fresh twitter account, no delay, boot server, look at profile timeline for duplicate posts.

Discord username

cjft

ChristopherTrimboli avatar Dec 21 '24 10:12 ChristopherTrimboli