faker icon indicating copy to clipboard operation
faker copied to clipboard

Published 20 hours ago • verified publisher icon elixirs

Change data storage to files

Open laraujo7 opened this issue 3 years ago • 3 comments

I've added:

  • [ ] USAGE.md docs if applicable
  • [ ] CHANGELOG.md

laraujo7 avatar May 17 '22 14:05 laraujo7

@vbrazo So, I wondered if we could move the data passed in the functions to a file, which would improve the reading of the modules. This was my attempt, but I didn't know which type of file to use, so I left it as a txt. Do you think a yml or a json file would be better?

I would be down to change everything if it gets accepted 👍.

laraujo7 avatar May 17 '22 15:05 laraujo7

So, I made some changes after running the benchmark as I found out that my solution was a bit slower. After my optimization, this was the result.

Screenshot 2022-05-17 at 17 55 44

What do you think @vbrazo ?

laraujo7 avatar May 17 '22 17:05 laraujo7

This would make contributing to Faker much easier! :pray:

nelsonmestevao avatar Aug 08 '23 11:08 nelsonmestevao