tesla icon indicating copy to clipboard operation
tesla copied to clipboard
verified publisher icon elixir-tesla

Mint passive mode

Open teamon opened this issue 4 years ago • 3 comments

tl;dr

Switch Tesla.Adapter.Mint to use passive mode, as suggesting in https://github.com/teamon/tesla/issues/357#issuecomment-916967770

(Potentially) related issues:

  • https://github.com/teamon/tesla/issues/357
  • https://github.com/teamon/tesla/issues/450
  • https://github.com/teamon/tesla/issues/394
  • https://github.com/teamon/tesla/issues/385
  • https://github.com/teamon/tesla/issues/370

teamon avatar Dec 17 '21 14:12 teamon

@teamon I'd like to tackle this one

fbergero avatar May 06 '22 23:05 fbergero

@teamon We basically want to change the default active mode to passive here https://github.com/elixir-tesla/tesla/blob/master/lib/tesla/adapter/mint.ex#L51 right?

Doing that only breaks some tests about how passive mode returns timeout. I'll fix those but can't think of any other test to add for this feature.

fbergero avatar May 08 '22 14:05 fbergero

Basically yes :)

In case of tests it would be great to have failing test cases for all related issues and then check if changing to passive mode fixes them.

teamon avatar May 09 '22 09:05 teamon