tesla icon indicating copy to clipboard operation
tesla copied to clipboard

Ship Rhobust Tape Adapter

Open jherdman opened this issue 5 years ago • 6 comments

Having code for a Tape adapter is just one step away from actually shipping one. Why not just ship it too?

jherdman avatar May 20 '20 01:05 jherdman

I assume you mean this tape wiki entry.

This is really just a small example - to make it really robust and usable it would require some work, especially configuration and potentially using the test context to choose responses.

teamon avatar May 27 '20 12:05 teamon

Is it worth shipping what's in the wiki entry as a means of getting a foot in the door toward a more complete solution?

jherdman avatar May 27 '20 15:05 jherdman

I don't think so. Once something is put in master/released version it must stay there and be supported forever (or at least until next major version).

If you simply copy & paste the wiki version into your codebase it is trivial to modify the code when needed. On the other hand, If it is a part of tesla package then you need to either fork tesla itself or copy & paste the adapter code under a different name anyway.

In case anyone is willing to submit a decent version of Tape adapter I'm open to putting it into master.

teamon avatar Jun 15 '20 08:06 teamon

👋 I'm working on an adapter for our use case. I'd be happy to share the code here and open up the discussion about the required features.

stefanchrobot avatar Dec 22 '20 22:12 stefanchrobot

@stefanchrobot 👋

teamon avatar Dec 17 '21 14:12 teamon

@teamon Well, time passed pretty quickly 😅 We haven't done any changes to our implementation so it seems it pretty stable. Let me figure out a way to publish the code. Although I'm thinking more about providing this as an external package, at least initially.

stefanchrobot avatar Dec 17 '21 14:12 stefanchrobot