exqlite icon indicating copy to clipboard operation
exqlite copied to clipboard

Add insert_all

Open ruslandoga opened this issue 1 year ago • 3 comments

This PR adds a helper NIF that can be used to bulk-insert "unlimited" number of rows.

Should be enough to clоse https://github.com/elixir-sqlite/exqlite/issues/129 once it gets into ecto_sqlite3

Regarding performance: XQLite uses this approach in insert_all benchmark in https://github.com/ruslandoga/elixir-sqlite-bench

ruslandoga avatar Oct 14 '24 04:10 ruslandoga

This looks good.

warmwaffles avatar Oct 14 '24 13:10 warmwaffles

I do not like how often the windows test flaps.

warmwaffles avatar Oct 14 '24 14:10 warmwaffles

Ugh

c_src\sqlite3_nif.c(703): error C2057: expected constant expression
c_src\sqlite3_nif.c(703): error C2466: cannot allocate an array of constant size 0
c_src\sqlite3_nif.c(703): error C2133: 'types_array': unknown size

warmwaffles avatar Oct 14 '24 14:10 warmwaffles