scholar
scholar copied to clipboard
Refactor Scholar.Neighbors
As argued in #254, we need to update Scholar.Neighbors
in the following way:
- [x] Add
BruteKNN
module that implements brute-force k-NN search. Itspredict
function has to return{neighbor_indices, neighbor_distances}
. Makebatch_size
an option (as in #253). - [ ] Implement
KNNClassifier
. - [ ] Implement
KNNRegressor
. - [ ] Deprecate
Scholar.Neighbors.KNearestNeighbors
.
KNNClassifier
and KNNRegressor
have to take k-NN algorithm and metric options as atoms, but also allow for custom k-NN algorithms and metrics to be passed as modules and functions, respectively.