elixir_sense icon indicating copy to clipboard operation
elixir_sense copied to clipboard

Make expansion AST pass to be typed-based

Open josevalim opened this issue 1 year ago • 0 comments

Today, the pass returns the expanded AST. However, I don't think elixir_sense actually needs the AST. Instead, it must pass type information around. My suggestion is for it to track at first:

  • {:struct, name}
  • {:atom, name}
  • dynamic

Dynamic can be the default type for anything you don't know what the return is.

This also means the current implementation can be simplified:

  1. There is no need to build the ast for quote
  2. There is no need to traverse the right side of :: in binaries (the implementation can be much simpler)

Open questions and Elixir improvements:

  1. Do you need to port Elixir's rewrite rules? If so, we should expose this in Elixir itself
  2. Can we support Record, Protocol, ExUnit.Case without adding special rules? Carrying type information, especially atoms, may actually help here. Should we improve something in Elixir to make this possible?
  3. There may be other complex areas we should ask Elixir to expose. If so, which?

These topics have been first brought up here: https://github.com/elixir-lsp/elixir_sense/pull/293

josevalim avatar Oct 07 '24 13:10 josevalim