elixir-ls icon indicating copy to clipboard operation
elixir-ls copied to clipboard

Published 20 hours ago • verified publisher icon elixir-lsp

Do not emit Code Lens when file has merge conflicts

Open beatrixada opened this issue 4 years ago • 2 comments

Environment

  • Elixir & Erlang versions (elixir --version): Erlang/OTP 23 [erts-11.2] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1] [hipe]

Elixir 1.11.4 (compiled with Erlang/OTP 23)

  • VSCode ElixirLS version: 0.7.0
  • Operating System Version: darwin 20.4.0

Troubleshooting

  • [x] Restart your editor (which will restart ElixirLS) sometimes fixes issues
  • [x] Stop your editor, remove the entire .elixir_ls directory, then restart your editor

When "Suggest Specs" is turned on, the inline Code Lens options for resolving merge conflicts do not work. This was already documented in elixir-lsp/vscode-elixir-ls#123 but it was closed by the creator because disabling spec suggestions fixes it. Ideally these features would be able to coexist. I'm happy to look into fixing this if someone can point me in the right direction for where the spec suggestions are implemented.

beatrixada avatar May 11 '21 15:05 beatrixada

IMO it's vscode issue that is not able to display Code Lens from two different extensions. Nothing can be done on our side.

lukaszsamson avatar May 22 '21 21:05 lukaszsamson

The extension should probably not be trying to display Code Lens for typespecs in buffers that have merge conflicts, as they are syntactically invalid and attempting to compile them or pass them to Dialyzer will fail. If this is a problem with VS Code, has an issue been opened about it?

beatrixada avatar May 23 '21 01:05 beatrixada