gen_stage icon indicating copy to clipboard operation
gen_stage copied to clipboard

Published 20 hours ago • verified publisher icon elixir-lang

Add support for `handle_continue/2` callback

Open maartenvanvliet opened this issue 2 years ago • 4 comments
trafficstars

I took the liberty to address the feedback for this PR https://github.com/elixir-lang/gen_stage/pull/264 as it was open for more than a year. @hazardfn hope you are okay with this?

GenServers also support a timeout in the return value {:ok, state, timeout | :hibernate | {:continue, term}}which is currently not supported by GenStage. I've added this too.

maartenvanvliet avatar May 11 '23 20:05 maartenvanvliet

@josevalim could you have a look?

maartenvanvliet avatar May 30 '23 08:05 maartenvanvliet

@whatyouhide I know you reviewed the last revision - any chance you can take a look at this one? 🙏

acco avatar Mar 15 '24 20:03 acco

@josevalim @whatyouhide - Hi there! I was just looking for this feature to enable timer base scheduling in my GenStage producer. Is there a chance this could be approved soon?

VasiliyS avatar Sep 19 '24 12:09 VasiliyS

I need to sit down and review it. The issue is that we need to consider all possible execution scenarios for producers, consumers, and producer_consumer, and those are not trivial. So I need to be in the proper headspace and other tasks take priority at the moment. Sorry.

josevalim avatar Sep 19 '24 12:09 josevalim