elixir-lang
CI: Various improvements to ci.yml
Hi @eksperimental, I am not planning to go ahead with those changes for now.
- The erlc one will be removed soon anyway
- We still want to test deterministic to improve our coverage with the flag
- I think CI is a perfectly fine name
Thanks,
I reopened the PR because we should merge the path changes. Is there a way to only run the docs one when only those files change? 🤔
That was the original reasoning behing moving the doc building to its own action.
There's an action that can filter paths on a job/step level, its this one: https://github.com/dorny/paths-filter
Yeah, I understand now it was the original rationale but we change the code more often than we change those pages, so optimizing for faster general changes is better. I guess we could run some git command that aborts the other runners, except the docs one, if the diff only lists those directories?
Yes. detecting changes with git is the other option to detect changes, aborting other runners I will have to look into that.
I tried to implement a solution using git diff but I was not really happy with it and I don't think it would cover all the cases and I felt I was reinventing the wheel.
So I ended up implementing a solution with https://github.com/dorny/paths-filter
I was a bit reluctant to add an external action, but this one is used by Sentry and Google Chrome. I can submit a new PR if you are interested.
Since you did the work, please do send a PR! Worst case scenario it will work for documentation purposes!
I have a working version that uses git diff, I will be sharing it tomorrow.