elixir icon indicating copy to clipboard operation
elixir copied to clipboard

Add support for sigils containing integers

Open starbelly opened this issue 1 year ago • 4 comments

This commit adds support for sigils containing integers. Integers must be proceeded by an upper case alpha, but can otherwise be mixed (e.g., ~A1B2C3).

starbelly avatar Mar 27 '24 14:03 starbelly

Note: I will update sigil docs when a signal this is to be accepted is received :)

starbelly avatar Mar 27 '24 15:03 starbelly

I come here with zero context. Was this discussed in the ML or somewhere else?

whatyouhide avatar Mar 27 '24 16:03 whatyouhide

I come here with zero context. Was this discussed in the ML or somewhere else?

As is tradition, I give you a context fail 😄 No, this was not discussed on the ML, it simply came up informally on EEF slack. The original context is a potential need to add a sigil that corresponds to a library name that ends with a digit ~HL7.

starbelly avatar Mar 27 '24 16:03 starbelly

Gotcha @starbelly no probs, I was just checking. Thanks for the info. 🙏

whatyouhide avatar Mar 27 '24 16:03 whatyouhide

@josevalim I think this is good now, but let me know if more adjustments should be made.

starbelly avatar May 16 '24 02:05 starbelly

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

josevalim avatar May 17 '24 10:05 josevalim