elixir-error-tracker
Fix action buttons
Hi, I was trying the new mute action and it caught my attention that, while the Resolve / Unresolve action is a button, the new Mute / Unmute action is a link. Both should be buttons, as they trigger actions, aren't used for navigation.
Making both actions as button provides a unified experience when using the keyboard, as buttons can be triggered using the space and return keys, whereas links can't be triggered with the space key.
I'm working on a PR that also fixes the Unmute action as it's currently broken in two lines.
Here's my work in progress, as soon as I fix the responsive design for it I'll send a PR if that's OK.
https://github.com/user-attachments/assets/480565de-421a-43d0-9acc-ea45304125b8
My pleasure!
I'm working on it but changing the design is a bit slow as there's no live reload. Am I missing something in the dev setup? I have to restart the server after every change...
My pleasure!
I'm working on it but changing the design is a bit slow as there's no live reload. Am I missing something in the dev setup? I have to restart the server after every change...
You are not missing anything @jaimeiniesta. I've opened an issue in the Phoenix Playground repository a couple days ago about this same issue https://github.com/phoenix-playground/phoenix_playground/issues/24
Unfortunately I didn't have time to take a look at the LiveScript project yet.
