desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Gracefully handle erlang-wx compiled without wxWebView support

Open adamwight opened this issue 3 years ago • 3 comments

Prints an actionable warning and falls back to a browser view.

adamwight avatar May 13 '22 20:05 adamwight

This looks good. Did you test this on the other operating systems, or are you just assuming it works fine? I'll run some smoke tests on Mac/Windows/Linux in the later case

dominicletz avatar May 16 '22 11:05 dominicletz

I'll will want to keep the windows user specific warning about installing the edge webview. So I'll have a look on windows here and add a commit

dominicletz avatar May 17 '22 12:05 dominicletz

This looks good. Did you test this on the other operating systems, or are you just assuming it works fine? I'll run some smoke tests on Mac/Windows/Linux in the later case

I didn't have a chance to test on other systems, unfortunately. I'm using Debian 11.3 and tested with the erlang-solutions.org packages, both the full ESL bundle and the discrete packages, and also with a locally-compiled installation.

I'll will want to keep the windows user specific warning about installing the edge webview. So I'll have a look on windows here and add a commit

Thanks! I'd like to set up a windows VM for testing this sort of thing, but it sounds like you'll get to this before I do.

I... may have overreacted a bit to the way that the notice was being passed up the call hierarchy. It seems that the code was returning a wxHtmlWindow which doesn't seem to share any base interface with wxWebView. Very possible that I'm completely misunderstanding the code which handles this. But is it possible to just show the html window from within Fallback rather than returning this object?

adamwight avatar May 22 '22 10:05 adamwight