crawly icon indicating copy to clipboard operation
crawly copied to clipboard

Published 20 hours ago • verified publisher icon elixir-crawly

Update csv_encoder.ex

Open jack-s9 opened this issue 3 years ago • 4 comments

  • Add code formatting around iex example for Crawly.Pipelines.CSVEncoder docs

jack-s9 avatar Dec 29 '21 05:12 jack-s9

@jack-s9 thanks for the fix, code indentation does not actually require backticks, see here https://hexdocs.pm/elixir/1.13/writing-documentation.html

could you remove the backticks and add in the additional line after the header? i think the parser requires a newline.

Checks are failing are on me, will fix. thanks for contrib!

Ziinc avatar Jan 31 '22 11:01 Ziinc

I made the change to remove the backticks. I'm pushing changes from the GitHub web interface and wasn't sure how to squash my commits. Let me know if you need any other changes.

jack-s9 avatar Feb 01 '22 05:02 jack-s9

Hey. As far as I see, it failed on --check-formatted step. Could you please format the code so I can merge it? @jack-s9

oltarasenko avatar Feb 01 '22 20:02 oltarasenko

@oltarasenko coveralls uploading doesn't work for PRs, for some reason.

Ziinc avatar Feb 06 '22 16:02 Ziinc