crawly icon indicating copy to clipboard operation
crawly copied to clipboard

Remove URL fragment before storing in `Crawly.Middlewares.UniqueRequest`

Open tanguilp opened this issue 3 years ago • 3 comments

Usually a fragment leads to the same page.

tanguilp avatar Dec 04 '20 12:12 tanguilp

Yes, it will improve the situation! I will add it to the scope.

oltarasenko avatar Dec 07 '20 14:12 oltarasenko

@Ziinc Is this issue still open? Looking for something to work on. If it is still open, please help with a description of the issue.

oshosanya avatar Feb 09 '22 14:02 oshosanya

I think you should change the file /lib/crawly/middlewares/unique_request.ex

The fragment could be removed with something like

"http://example.com/faqs#one" |> URI.parse |> Map.put(:fragment, nil) |> URI.to_string

I could submit a pull request about this small change

Regards Matteo

matteoredaelli avatar Apr 02 '22 12:04 matteoredaelli