TESK icon indicating copy to clipboard operation
TESK copied to clipboard

feat(ci): add `pre-commit`

Open JaeAeich opened this issue 9 months ago • 4 comments

Add precommit, initialize it with necessary checks to keep code change abide by a standard.

Please look at .pre-commit.config for all the hooks that are added.

For reviewer's sake, listing some config that have changed alot of files:

Note: This introduces a discrepancy in the checks between CI and pre-commit, it won't be hard (if someone wanted to) bypass precommit checks and push the code changes. Given adding all the hooks to CI as well might slow CI down, I thinks this discrepancy is the sweet spot. CI has checks for very absolutely necessary checks and pre-commit has some necessary and many nice-to-have checks.

EDIT: THIS pre-commit IS JUST FOR CI, NOT ADDED AS A git HOOK.

JaeAeich avatar May 24 '24 13:05 JaeAeich