nixos-infect
nixos-infect copied to clipboard
elitak
docs, tests, updates, bug fixes, and more
use nixos-unstable channel by default improved and updated documentation tested and documented installing on different DO Images fix install on Debian (requires xz-utils) fix networking.nix formatting fix networking.nix (eth1) interface detection use a few (not all! some are wrong!) shellcheck suggestions
Hi! I did this a long time ago but didn't get around to making a PR... and now there are conflicts I see and possibly a fix for something I fixed (debian 10). I can resolve that if you like if this is a PR you're interested in. am maybe also willing to work with to make it something you are if it's not good as is. I did a lot of other improvements too. I can remove the change to use nixos-unstable too as that's probably not what you want.
Yeah, I'd merge this if you could clear up the conflicts. Omit the nixos-unstable change.
I'm ambivalent about bloating up the file with documentation, but I suppose it's better to err on the side of too much, rather than too little.
Appreciate the help; thanks.
Why do yo want to use the nixos-unstable branch by default? Wouldn't it be better do have the defaults as 'stable' as possible?
@DavHau i use nixos-unstable so that's what i had. :) simple as that. i'm modifying that part of it as i can appreciate that other people would rather have something else by default.
@elitak i'm working on resolving the conflicts right now. should i leave it at 19.09 or update it to 20.03 which was released yesterday? :grinning:
also: i'm a bit perplexed by this https://github.com/elitak/nixos-infect/commit/f5da2577ddc924c0ee725fe9729cbf32b3f44808 which is what's conflicting. what i had was working for debian 10 on digital ocean. maybe other places it doesn't work?
Go with 20.03, if you're going to be testing it. You'd have to ask the other authors about why they changed what, I don't have any direct experience with those platforms.
On Tue, Apr 21, 2020 at 7:38 AM Kiwi [email protected] wrote:
@DavHau https://github.com/DavHau i use nixos-unstable so that's what i had. :) simple as that. i'm modifying that part of it as i can appreciate that other people would rather have something else by default.
@elitak https://github.com/elitak i'm working on resolving the conflicts right now. should i leave it at 19.09 or update it to 20.03 which was released yesterday? 😀
also: i'm a bit perplexed by this f5da257 https://github.com/elitak/nixos-infect/commit/f5da2577ddc924c0ee725fe9729cbf32b3f44808 which is what's conflicting. what i had was working for debian 10 on digital ocean. maybe other places it doesn't work?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elitak/nixos-infect/pull/52#issuecomment-617221467, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF3YMOVPQ6TWLR5HXKPKATRNWVXDANCNFSM4MMTTYIQ .
@Kiwi any update on this?
I haven't finished fixing the merge conflicts. I was thinking about this the other day though. I have a bit more time now than I did so I should get back to it soon (I haven't been doing much with it lately).