Eli Simhayev
Eli Simhayev
PR is green
@amyeroberts, thank you for the comprehensive CR! I sincerely appreciate the effort and time you dedicated to thoroughly assessing this pull request. Will be fixed!
CR changes I did: * Added `layer_norm_eps` * Model layers are now take the config, except the `AutoformerAttention` which I wasn't sure about * Better variables names * Addressed questions...
PatchTST is in Gluon, thanks to @kashif . Closing here :) https://github.com/awslabs/gluonts/pull/2748
Looked into the falling tests, looks like it's not related to the change (correct me if I'm wrong) 🙂
> very cool! Having a look shortly! Wow you saw it fast! right now it's just the template of the vanilla TS transformer. BTW I sent you an email :)
Hi, @NielsRogge and @kashif 🙂 Maybe you have an example for a conversion script? I'm following the [How to add a model to 🤗 Transformers?](https://huggingface.co/docs/transformers/add_new_model), section six "Write a conversion...
> thanks! having a look! Work is still in progress, but you might have a look if you have time :) And by the way, your implemention and the vanilla...