Silent-Hill-2-Enhancements icon indicating copy to clipboard operation
Silent-Hill-2-Enhancements copied to clipboard

XIDI wrapper requires msvcp140_atomic_wait.dll, and it's bad

Open Psycho-A opened this issue 1 year ago • 5 comments

If we're using dinput8.dll wrapper of Xidi controller enhancer, it force requires msvcp140_atomic_wait.dll which is only MSVC 2022 component. Why this is bad?

  1. Most of (even) modern software still not require VC 2022 update and uses 2019 at max, which means excess time and installations for users.

  2. SH2EE still natively supports Windows XP, which doesn't allow use VC 2022. I know what young people think about old systems in 2024 - but if the support is still announced and technically exist - it would be fair to carry it as long as it's possible, to wide players' circle (with no shader additions, the game still have smallest system reqs even with all EE assets).

Psycho-A avatar Feb 17 '24 20:02 Psycho-A

We don't have much control over the Xidi code. That is another project. I did, however, compile it without the need for the VC 2022 runtime. However, it still won't work properly on Windows XP because it cannot be complied for Windows XP without some of the code being rewritten.

elishacloud avatar Feb 17 '24 21:02 elishacloud

Hm, then the time has come to drop the support with the newest update?

Pocokk avatar Feb 22 '24 01:02 Pocokk

However, it still won't work properly on Windows XP because it cannot be complied for Windows XP without some of the code being rewritten.

Then maybe it would be good to make this component additional for the install? Far not every player needs support for XInput controllers.

Hm, then the time has come to drop the support with the newest update?

Drop it yourself on your machine and stop agitate. It is totally absurd to drop support because of some auxiliary component.

Psycho-A avatar Mar 28 '24 13:03 Psycho-A

This component is already optional. Users can choose to use it or not. All other components should work fine on Windows XP. Though DSOAL is probably not needed on Windows XP.

image

elishacloud avatar Apr 06 '24 15:04 elishacloud

This component is already optional. Users can choose to use it or not. All other components should work fine on Windows XP. Though DSOAL is probably not needed on Windows XP.

Thanks for the anwser - it's very good then! Although if you further improve the experience, you can add an OS version check to the installer script, so that incompatible items don't appear in the Components list at all. Otherwise, the player may choose them and then not understand why the game doesn't run for him. By the way, DSOAL, as far as I remember, does not work on Windows XP either.

Psycho-A avatar Apr 23 '24 11:04 Psycho-A