ddquery icon indicating copy to clipboard operation
ddquery copied to clipboard

Inconsistency between Git tag (0.1) and PyPI published version

Open kyanny opened this issue 5 years ago • 0 comments

Hi @elinaldosoft,

I noticed that there is an inconsistency between the Git tag 0.1 and the package published at PyPI. While Git tag 0.1 contains a bug fix commit https://github.com/elinaldosoft/ddquery/commit/69e8589c5c997bc9b66a5b4b390931a704a66595, it isn't included the source code available from PyPI.

~/ghq/github.com/elinaldosoft/ddquery tags/0.1
❯ git log -1
commit 69e8589c5c997bc9b66a5b4b390931a704a66595 (HEAD, tag: 0.1)
Author: Elinaldo Nascimento <[email protected]>
Date:   Mon Jul 10 14:46:36 2017 -0300

    Fixbug: check if exist attr duration in object record, no exist in migrations

~/ghq/github.com/elinaldosoft/ddquery tags/0.1
❯ git diff --no-index ddquery.py ~/Downloads/ddquery-0.1/ddquery.py
diff --git a/ddquery.py b/Users/kensuke.nagae/Downloads/ddquery-0.1/ddquery.py
index bbad1ab..9984992 100644
--- a/ddquery.py
+++ b/Users/kensuke.nagae/Downloads/ddquery-0.1/ddquery.py
@@ -29,8 +29,7 @@ class SqlFormatter(logging.Formatter):

         if self.parse:
             sql = sqlparse.format(sql, reindent=self.reindent, keyword_case=self.keyword_case)
-            if hasattr(record, 'duration'):
-                sql = "({0:.3f}ms) {1}".format(record.duration, sql)
+            sql = "({0:.3f}ms) {1}".format(record.duration, sql)

         if self.highlight:
             sql = highlight(

Anyway, it's good to publish a new version to PyPI, because it's been a long time since the latest published date (Jul 10, 2017) and there are more changes you've made on this repository.

kyanny avatar Nov 10 '20 07:11 kyanny