webapp icon indicating copy to clipboard operation
webapp copied to clipboard

Move "Connect Wallet" button to drawer when small screen size

Open nya-elimu opened this issue 3 years ago • 20 comments

There is not enough space for the Connect Wallet when the browser's screen size is small. As a solution to this, display the "Connect Wallet" in the drawer (above the "Sign on" link) when the screen width is small.

Screen Shot 2021-07-28 at 9 34 02 PM

Screen Shot 2021-08-18 at 2 04 10 PM
  • Relates to #1270
  • Depends on #1423

nya-elimu avatar Jul 28 '21 19:07 nya-elimu

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.01 ETH (29.98 USD @ $2997.96/ETH) attached to it as part of the elimu-ai fund.

gitcoinbot avatar Aug 18 '21 12:08 gitcoinbot

@cravend Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Aug 22 '21 16:08 gitcoinbot

Hey y'all, just wanted to send a quick status update. I had a little bit of trouble getting everything running locally, but I think I got it working. Looking forward to diving into this!

cravend avatar Aug 23 '21 12:08 cravend

Hey y'all, just wanted to send a quick status update. I had a little bit of trouble getting everything running locally, but I think I got it working. Looking forward to diving into this!

@cravend Thanks, Dalton. Let us know if we can help you with anything.

nya-elimu avatar Aug 24 '21 06:08 nya-elimu

Got it working! Just going through and checking the other pages (/admin, /analytics, etc) to make sure I didn't miss anything.

Page Menu
image image

cravend avatar Aug 27 '21 15:08 cravend

Screenshot 2021-08-27 at 18 32 35 @nya-elimuai for the admin page (and presumably), there's not enough room to keep both buttons (this screenshot is still a "large" breakpoint). What do you think about always having the "connect wallet" button be in the menu, other than on the homepage?

cravend avatar Aug 27 '21 16:08 cravend

@cravend Excellent work, thank you! 👏

Could you create a pull request for merging your branch into the main branch so that we can test the code changes? Please put me, @Shubham-Vishwakarma and @UmenR as the reviewers.


Regarding there not being enough room for the "Connect Wallet" button when the breadcrumbs + the contributor's name/e-mail is long is a good point, and definitely something we should fix. I think we should create a separate GitHub issue for that. For this issue, however, let's keep the amount of code changes as small as possible 🙂

nya-elimu avatar Aug 29 '21 11:08 nya-elimu

I think displaying the email of contributor is not necessary. It can be saved in code to be used elsewhere. But on the frontend only first name should be sufficient

For people like me Shubham Vishwakarma, the full name itself is too big. Hence first name should be enough.

Shubham-Vishwakarma avatar Aug 29 '21 16:08 Shubham-Vishwakarma

I agree with @Shubham-Vishwakarma's suggestion to hide the e-mail. I made a separate GitHub issue for that here: https://github.com/elimu-ai/webapp/issues/1417

nya-elimu avatar Aug 29 '21 19:08 nya-elimu

@cravend Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Sep 05 '21 16:09 gitcoinbot

PR: #1418

cravend avatar Sep 05 '21 17:09 cravend

@cravend Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Sep 09 '21 16:09 gitcoinbot

Still working, going to check out the review request changes today.

cravend avatar Sep 10 '21 07:09 cravend

⚡️ A tip worth 0.01000 ETH (32.94 USD @ $3293.74/ETH) has been granted to @cravend for this issue from @nya-elimuai. ⚡️

Nice work @cravend! Your tip has automatically been deposited in the ETH address we have on file.

  • $5350581.42 in Funded OSS Work Available at: https://gitcoin.co/explorer
  • Incentivize contributions to your repo: Send a Tip or Fund a PR
  • No Email? Get help on the Gitcoin's Discord

gitcoinbot avatar Sep 14 '21 09:09 gitcoinbot

@cravend Thank you, Dalton. We can take over your pull request from here.

ETH transaction: https://etherscan.io/tx/0x268a6dc0e884fc491f39ad67c779c31184354b28085a9bb3b61c43a80917a13c

nya-elimu avatar Sep 14 '21 09:09 nya-elimu

Perfect, thanks so much for the opportunity! Let me know if anything else needs done — I'm happy to help out. Y'all have a good mission :)

cravend avatar Sep 14 '21 10:09 cravend

@cravend Your $ELIMU 💎 token rewards: https://etherscan.io/tx/0x3fc9bcf7cd34bb2339893ae609bb9aa34a0526c932d18072da9a02f925e5cc0f

nya-elimu avatar Dec 20 '21 12:12 nya-elimu

Awesome, thanks so much!

cravend avatar Dec 20 '21 12:12 cravend

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.01 ETH (29.15 USD @ $3043.84/ETH) attached to this issue has been cancelled by the bounty submitter

gitcoinbot avatar Apr 19 '22 09:04 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.01 ETH (11.70 USD @ $1169.61/ETH) attached to this issue has been cancelled by the bounty submitter

gitcoinbot avatar Jul 05 '22 09:07 gitcoinbot

Replaced by https://github.com/elimu-ai/web3-wiki/issues/39

nya-elimu avatar Jul 05 '24 05:07 nya-elimu