mumbl icon indicating copy to clipboard operation
mumbl copied to clipboard

mumbl.track(0) starts playing music when SM2 is used

Open NV opened this issue 14 years ago • 3 comments

I've made a demo page to force Firefox use SM2 http://github.com/NV/mumbl/compare/gh-pages

http://nv.github.com/mumbl/demo/

Firefox: music starts playing immediately. Chrome, Safari: music starts playing when the play button is hit (as expected).

NV avatar Nov 01 '10 13:11 NV

This will be fixed in mumbl 1.0 where I drop explicit HTML5 support in favor of the new HTML5 support built-in to SM2. If it's really important to you, it should be trivial enough to fix.

Sorry about the lack of support in mumbl. I made it when HTML5 audio implementations were still pretty buggy and web API support in Songbird was still very incomplete, so I couldn't really test it that well across platforms.

eligrey avatar Nov 01 '10 19:11 eligrey

If the fix is a trivial then would you mind to share it?

I wouldn't call it the lack of support since you're answering all my bug reports very quickly :)

NV avatar Nov 01 '10 19:11 NV

I'm too busy to actively work on this, but I think you will want to examine how I do track() in SM2 and then see how that can be fixed. From a quick glance, it looks like playSound() is the culprit. If you fix this, please add a unit test (if possible) and push the changes to your fork. I'll accept a pullreq if you submit one.

eligrey avatar Nov 01 '10 19:11 eligrey