classList.js icon indicating copy to clipboard operation
classList.js copied to clipboard

DOMException is undefined in IE8

Open axelboc opened this issue 9 years ago • 3 comments

Line 50 throws a DOMException is undefined error in IE8:

this.code = DOMException[type];

Has nobody ever encountered this error before!? It seems that DOMException is indeed not supported at all on IE8:

  • http://www.webbrowsercompatibility.com/dom/desktop/ https://msdn.microsoft.com/en-us/library/ff974354
  • https://msdn.microsoft.com/en-us/library/ff974354

axelboc avatar Mar 31 '16 05:03 axelboc

Has nobody ever encountered this error before!?

Luckily, functionally an error is still going to be thrown as intended, but for the wrong reasons (meaning that this bug isn't going to break anyone's code but I should still fix it). Thanks for bringing this up, and I'll patch it some time this week (if I forget to by Saturday, please remind me)

eligrey avatar Mar 31 '16 06:03 eligrey

cough has this been patched? tomorrow is saturday :-P

tschallacka avatar Sep 02 '16 11:09 tschallacka

@tschallacka I'm very busy with my commercial work atm, but I will eventually get to this. If you cannot wait, I will review any pull requests that you have for me.

eligrey avatar Sep 02 '16 18:09 eligrey