FileSaver.js icon indicating copy to clipboard operation
FileSaver.js copied to clipboard

Version 2+ does not work with Chrome popup blocker extension

Open cosme-benito opened this issue 5 years ago • 3 comments

From version 2.0 forward, every time the user tries to download a file, a popup notification shows up and the file doesn't download (even if the user presses the "show popup" or "whitelist this site" button). This does NOT happen with version 1.3.8.

I managed to reproduce this problem by using the "Poperblocker' extension, which can be found here: https://poperblocker.com/

JSFiddle with 2.0.2: https://jsfiddle.net/sdu4xcne/1/

JSFiddle with 1.3.8: https://jsfiddle.net/qeujogs4/

cosme-benito avatar May 24 '19 11:05 cosme-benito

I created a PR which fixes this issue. I don't love the solution since it's a bit obscure, but it is simple and fixes the conflict with this Chrome extension.

micahjon avatar Jun 07 '19 18:06 micahjon

Was the PR for this merged, or does this problem still exist? Looks like Safari still sees FileSaver.saveAs() as a pop-up window (like a window.open).

joriswitteman avatar Jul 11 '22 11:07 joriswitteman

Nop, as you can see it's still open !568

cosme-benito avatar Jul 11 '22 12:07 cosme-benito