elife-xpub icon indicating copy to clipboard operation
elife-xpub copied to clipboard

Changes to submitSurveyResponse mutation

Open Cooryd opened this issue 4 years ago • 1 comments

Task

https://github.com/elifesciences/elife-xpub/blob/7dbf9888bf1f852a1bb0dbf31dbf86c4a06387ee/packages/component-submission/server/typeDefs.graphqls#L12 the submitSurveyResponse mutation currently takes a single data variable which is type SurveySubmission, this adds a layer of abstraction which could be removed by having three variables sent as part of the mutation call.

We should also be returning a Survey object back on this call instead of a Boolean as this is best practice with graphql.

Cooryd avatar Jul 12 '19 11:07 Cooryd