elide
elide copied to clipboard
fix(cli): correctly add nanorc resources to native image
Summary
This PR fixes a bug in native distributions of Elide, where the nanorc
configuration directory would not be unpacked correctly due to missing resource configuration entries in the GraalVM native image metadata, breaking syntax highlighting on most machines (specifically, those devices where $ELIDE_HOME/nanorc
was empty or didn't exist).
Hindsight
The issue was not obvious because the code that handled unpacking the default nanorc
files skipped entries that were not present in the resources, without raising any errors or logging messages.
A new warning log has been added to prevent this in the future.
Changelog
- fix(cli): add
nanorc
resources toresources-config.json
. - feat(cli): log a warning if a required
nanorc
configuration file is not found in the bundled resources.
Codecov Report
Attention: Patch coverage is 33.33333%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 56.76%. Comparing base (
5d849e1
) to head (1bd5be1
). Report is 3 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #922 +/- ##
==========================================
+ Coverage 56.74% 56.76% +0.01%
==========================================
Files 445 445
Lines 13648 13650 +2
Branches 2204 2204
==========================================
+ Hits 7745 7748 +3
- Misses 5129 5130 +1
+ Partials 774 772 -2
Flag | Coverage Δ | |
---|---|---|
gradle | 56.76% <33.33%> (+0.01%) |
:arrow_up: |
jvm | 56.76% <33.33%> (+0.01%) |
:arrow_up: |
lib | 56.76% <33.33%> (+0.01%) |
:arrow_up: |
plugin | 56.76% <33.33%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
...kotlin/elide/tool/cli/cmd/repl/ToolShellCommand.kt | 49.81% <33.33%> (+<0.01%) |
:arrow_up: |
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5d849e1...1bd5be1. Read the comment docs.
Great work as always. Will make it into 1.0.0-alpha10