Eli White
Eli White
This is an example element of the array of the JSON response for a search request: ``` { "name": "ProgressViewIOS.ios.js", "path": "Libraries/Components/ProgressViewIOS/ProgressViewIOS.ios.js", "sha": "76a1f5efb5294638826265b6a4009e6419da1fd4", "url": "https://api.github.com/repositories/214770447/contents/Libraries/Components/ProgressViewIOS/ProgressViewIOS.ios.js?ref=d5e5d39c2dd9822af07448ff47e44ed1df44d8e7", "git_url": "https://api.github.com/repositories/214770447/git/blobs/76a1f5efb5294638826265b6a4009e6419da1fd4", "html_url": "https://github.com/yinhangfeng/react-native-web/blob/d5e5d39c2dd9822af07448ff47e44ed1df44d8e7/Libraries/Components/ProgressViewIOS/ProgressViewIOS.ios.js",...
I think of these things I'd like to expose ``` path repository.name repository.owner.login ``` I think exposing these as environment variables is reasonable. Maybe matching https://github.com/NerdWalletOSS/shepherd/pull/88 with: ``` SHEPHERD_GITHUB_REPO_OWNER SHEPHERD_GITHUB_REPO_NAME...
The problem with the above proposal is that it runs all of these `should_checkout`s together, and it should be inline together. I implemented the above proposal and the output is...
I need to get the search results (or at least the data that will become the environment variables) at the time I'm running `forEachRepo`. I think that means that I...
I don't think this should be part of webdrivercss. Webdrivercss's job is to be a plugin to webdriverio to capture screenshots. Having assertion helpers seems like another package that would...
I happen to be of the belief that webdrivercss should have nothing to do with testing itself and thus shouldn't even have a tolerance setting. I think webdrivercss should purely...
This does not seem to be fixed in the current version and seems to be the largest perf hit for our screenshot task.
Does window.devicePixelRatio help? Figuring out the size and location of an element by scaling up like this: `element.offsetWidth * window.devicePixelRatio`. https://developer.mozilla.org/en-US/docs/Web/API/Window.devicePixelRatio
Someone should really try experimenting by scaling the crop rectangle by `window.devicePixelRatio` and see if that just solves this outright. I'm guessing it will.
> as of today, there is no simple programmatic way to know if a NPM package is a React Native library I may have missed this in a previous discussion,...