Elias Yishak
Elias Yishak
Currently blocked until analytics package has been added to flutter tools
Oh I wasn't aware of this command, this issue will aim at refactoring it with the new package's disable telemetry method as well then
For my own reference, the block of code that needs to be edited when the new analytics package gets onboarded to flutter-tools https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/commands/config.dart#L129-L142 ```dart if (argResults?.wasParsed('analytics') ?? false) { final...
> LGTM with minor question. > > I still advise a second thorough review from @eliasyishak. Yep still reviewing on my end as well
@gspencergoog friendly ping, does this look good to go?
Is this ready for review? I'm noticing two tests that are failing but they could be flakes?
Just a friendly ping from PR review incase we wanted to start this process now
> @eliasyishak can you review this one? Yep I'll take a look!
`Windows tool_integration_tests_1_6` flake for "allows overriding the directory for code size files"
Another example of the same test failing for this builder: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20tool_integration_tests_1_6/6787/overview
`Windows tool_integration_tests_1_6` flake for "allows overriding the directory for code size files"
Closing issue, PR: https://github.com/flutter/flutter/pull/125910 has added logging to this test incase it fails again