Elias Yishak
Elias Yishak
Still tracking on my todos but haven't got around to it yet as I figure out how to handle the breaking change that comes with it
@steniooliv if you have the time, can you check that this patch passes in your locale?
> > @steniooliv if you have the time, can you check that this patch passes in your locale? > > here there was an error: > > ``` > ❯...
@steniooliv have you also confirmed that you're on the right branch? If you're on the master branch on my fork, you won't have the updated code
This PR (https://github.com/flutter/flutter/pull/119243) from @LucaBreccia inspired this refactor
The regex pattern: `([0-9]*)\.([0-9]*)\.([0-9\.]*)` matches both of the versions below ``` Microsoft Windows [Versione 10.0.22621.819] Microsoft Windows [Version 6.1.7601] ``` The first group is the number of interest which ends...
Hi @steniooliv, yes this is the same problem for different locales. And while your PR does fix the issue, the better approach would be to use the windows command `ver`...
If you turn on the `runInShell` boolean to `true` in the run method, it will resolve the information correctly. We actually use this approach already within the tool here https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/base/os.dart#L568-L579...
@steniooliv I have started the leg work already, to save you the trouble, you can refer to my draft PR https://github.com/flutter/flutter/pull/119304 for how i refactored to use existing methods to...
Closing this issue since this was merged in this morning at https://github.com/flutter/flutter/pull/119304 Feel free to reopen if needed!