Elias Naur

> I'm not really sure what @marbar3778 is referring to, but you can't really avoid defer timing calls. The idea is that we have a config in the config struct...

Why not check and load the metric at the same time? Say, ``` defer telemetry.ModuleMeasureSince(types.ModuleName, time.Now(), telemetry.MetricKeyBeginBlocker) ``` becomes ``` if m := telemetry.Load(); m != nil { defer telemetry.ModuleMeasureSinceLocal(m,...

What's the alternative? Can you expand on https://github.com/cosmos/cosmos-sdk/issues/10245#issuecomment-1580885936?

> Well with my proposal, the APIs wouldn't be that much cleaner anyway. I think we might have to have `Emit*` functions for each type of metrics call supported. Then...

> can time.Now() be put into EmitMeasureSince? EmitMeasureSince is deferred, so its `time.Now` would be too late.

> 1. You're putting responsibility on the caller via `if m := telemetry.Load(); m != nil { ... }` > Yes, that's the clumsiness of my proposal. However, the idiom...

Alright. So what's the final API? https://github.com/cosmos/cosmos-sdk/issues/10245#issuecomment-1585302447 plus `telemetry.Now`?

Sounds like a reasonable optimization. Is this actively being worked on?

What is the status of this?

The initial release of the [`chdbg`](https://github.com/orijtech/chdbg) tool can now help diagnose `ConsensusHash` differences: ``` go run github.com/orijtech/chdbg bns-a.db bns-b.db chdbg: hash mismatch: 96AAD58DBDF2BA87D90BE1F620E80AC3D1662B5113A7667B51303596163A5969 != 56E581EBD9C0A3D726A91579839F7FF8A9251BEB063FDF0FA0415A0B3429DF6E chdbg: key _i.bchnft_owner:4C97A7423B1782D7C8CAB362247B848DEC96B1EC: key proofs...