elhussein

Results 33 comments of elhussein

I added the unit test but I don ,t have enough experience in unit test and also I don ,t ensure if this unit test work as expected or not...

Great I noticed this changes fix the issue of custom Image , so it ,s appear that custom image only needs this script ` ` from the `_editor_js.html` to solve...

Thanks @lb- very much , with your help I make this PR not draft and finally Ready for final review 🚀, see you in the next PR 😄 , I...

yes @lb- , I am very interested to continue to work on this issue , and already follow your [last comment](https://github.com/wagtail/wagtail/pull/11571#issuecomment-1923360591) , and I will take a look on this...

Great , Thanks @lb- for the detailed explanation.

Great ideas @lb- , as I already raised PR , so I already have basic understand of the problem ,so I will continue work in this issue on the another...

yes I agree, this what make this issue tricky > it's a good point about the counting of elements that may not be uniquely available in the DOM. plus we...

Thanks for replay @lb- , yes I just see `_editor_js.html` in more than file and make like it and not see #2936 . so I just have one question if...

there is simple solution may solve #2936 , and also the other gabs of this PR , if there is base template or a template that `RichTextField` in all pages...

Great , I will start working on this smart solution.